fix(k8sjwt): redact sensitive claims from logs#224
Open
Kyosuke Konishi (konippi) wants to merge 1 commit into
Open
fix(k8sjwt): redact sensitive claims from logs#224Kyosuke Konishi (konippi) wants to merge 1 commit into
Kyosuke Konishi (konippi) wants to merge 1 commit into
Conversation
2 tasks
Eitan Yarmush (EItanya)
approved these changes
Jun 18, 2026
Eitan Yarmush (EItanya)
left a comment
Eitan Yarmush (EItanya)
left a comment
Collaborator
There was a problem hiding this comment.
I wasn't aware of the slog.LogValuer interface before, I like the approach :)
Kyosuke Konishi (konippi)
force-pushed
the
fix/redact-k8sjwt-claims-logs
branch
from
6ca696c to
521e8ce
Compare
Contributor
Author
|
Rebased onto main to resolve the conflict from #270. Thanks for the review Eitan Yarmush (@EItanya)! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #103.
KubernetesClaimsnow implementsslog.LogValuervia a value receiver, so a logged copy cannot bypass redaction. Only non-sensitive claims (issuer, subject, audiences, timestamps, jti, namespace, service account, pod, node) are emitted; the secret name/UID and the resource UIDs are excluded.